←back to thread

446 points talboren | 9 comments | | HN request time: 0.505s | source | bottom
1. vintagedave ◴[] No.45037415[source]
I've read comments online (here on HN) that Github has been rewriting their UI in React and that it's got slower since. I have no knowledge if this is true or not (ie React -> speed direct correlation), and my own projects are small enough not to see any performance impact.

Does anyone have concrete information?

replies(2): >>45039147 #>>45039199 #
2. sleepytimetea ◴[] No.45039147[source]
They just pushed a new redesigned page for pull request diffs- must have bloated the DOM.
replies(1): >>45039445 #
3. fleebee ◴[] No.45039199[source]
I came across a blog post[1] (HN thread[2]) recently that sheds some light on the issue. The tl;dr is that the PR view can render over 100 000 DOM nodes, many of which are invisible inline SVG nodes, and SPA routing makes navigation a lot slower.

[1]: https://yoyo-code.com/why-is-github-ui-getting-so-much-slowe...

[2]: https://news.ycombinator.com/item?id=44799861

replies(1): >>45040341 #
4. mtmail ◴[] No.45039445[source]
I still see a little "try the new experience" link on the PR diff page (top right of page) so the rollout might be gradual. I won't click.
replies(2): >>45039531 #>>45039571 #
5. walthamstow ◴[] No.45039531{3}[source]
I am such a masochist that I actually click those buttons. If it's good, great, if it's shit, I have time to adjust before they foist it upon me anyway
replies(2): >>45040472 #>>45050109 #
6. herpdyderp ◴[] No.45039571{3}[source]
I tried it! I like it generally, but it’s too buggy. The whole diff explodes if you expand to more lines (for example). It’s easy to switch back.
7. joshmoody24 ◴[] No.45040341[source]
That blog post discovered that hard refreshing the page is faster than GitHub's SPA navigation, which led me to make this browser extension which makes GitHub navigation twice as fast:

https://chromewebstore.google.com/detail/make-github-great-a...

8. adithyassekhar ◴[] No.45040472{4}[source]
I am on insider previews and betas for all apps I use. You're not alone.
9. guappa ◴[] No.45050109{4}[source]
I prefer to delay the pain as much as possible instead