←back to thread

446 points talboren | 2 comments | | HN request time: 0s | source
Show context
vintagedave ◴[] No.45037415[source]
I've read comments online (here on HN) that Github has been rewriting their UI in React and that it's got slower since. I have no knowledge if this is true or not (ie React -> speed direct correlation), and my own projects are small enough not to see any performance impact.

Does anyone have concrete information?

replies(2): >>45039147 #>>45039199 #
1. fleebee ◴[] No.45039199[source]
I came across a blog post[1] (HN thread[2]) recently that sheds some light on the issue. The tl;dr is that the PR view can render over 100 000 DOM nodes, many of which are invisible inline SVG nodes, and SPA routing makes navigation a lot slower.

[1]: https://yoyo-code.com/why-is-github-ui-getting-so-much-slowe...

[2]: https://news.ycombinator.com/item?id=44799861

replies(1): >>45040341 #
2. joshmoody24 ◴[] No.45040341[source]
That blog post discovered that hard refreshing the page is faster than GitHub's SPA navigation, which led me to make this browser extension which makes GitHub navigation twice as fast:

https://chromewebstore.google.com/detail/make-github-great-a...