←back to thread

446 points talboren | 1 comments | | HN request time: 0.205s | source
Show context
vintagedave ◴[] No.45037415[source]
I've read comments online (here on HN) that Github has been rewriting their UI in React and that it's got slower since. I have no knowledge if this is true or not (ie React -> speed direct correlation), and my own projects are small enough not to see any performance impact.

Does anyone have concrete information?

replies(2): >>45039147 #>>45039199 #
sleepytimetea ◴[] No.45039147[source]
They just pushed a new redesigned page for pull request diffs- must have bloated the DOM.
replies(1): >>45039445 #
mtmail ◴[] No.45039445[source]
I still see a little "try the new experience" link on the PR diff page (top right of page) so the rollout might be gradual. I won't click.
replies(2): >>45039531 #>>45039571 #
1. herpdyderp ◴[] No.45039571[source]
I tried it! I like it generally, but it’s too buggy. The whole diff explodes if you expand to more lines (for example). It’s easy to switch back.