←back to thread

377 points NaOH | 4 comments | | HN request time: 0s | source
Show context
HanClinto ◴[] No.43793725[source]
This is so needed. This was a very encouraging article.

"Being a fan is all about bringing the enthusiasm. It’s being a champion of possibility. It’s believing in someone. And it’s contagious. When you’re around someone who is super excited about something, it washes over you. It feels good. You can’t help but want to bring the enthusiasm, too."

Stands in contrast to the Hemingway quote: "Critics are men who watch a battle from a high place then come down and shoot the survivors."

It feels socially safe, easy, and destructive to be a critic.

I'd rather be a fan.

replies(15): >>43793906 #>>43794073 #>>43794235 #>>43794376 #>>43794398 #>>43797022 #>>43797229 #>>43797763 #>>43797960 #>>43798310 #>>43798439 #>>43800608 #>>43801652 #>>43801753 #>>43801843 #
vunderba ◴[] No.43794376[source]
> It feels socially safe, easy, and destructive to be a critic. I'd rather be a fan.

Trotting out absolute statements does no one any good. I could just as easily spin this on its head and say that it feels socially safe to always show blind enthusiasm for the latest trend lest you be labelled a "hater".

It feels like we're just redefining critic to be synonymous with cynic. There's no reason that you can't simultaneously be both fan and a critic of X.

replies(6): >>43794580 #>>43795747 #>>43796069 #>>43796789 #>>43797687 #>>43801767 #
MrJohz ◴[] No.43794580[source]
In fact, the best critics of something are often its biggest fans. Roger Ebert, for example, wrote some pretty critical pieces, but nobody can deny that he was driven primarily by a love of cinema. Or take politics: I've seen people complain that left-wing commentators were too critical of Biden when they should have been criticising Trump, but often it's easier — and more useful — to criticise the things you like in the hope that they will improve, rather than spending all your time criticising something you don't like that will never listen to you.

That said, it's still important to take the time to sing the praises of something you like. If Ebert had spent all his time talking down bad films, reading his columns would have been painful drudgery (see also: CinemaSins, Nostalgia Critic, and similar attempts at film-criticism-by-cynicism). A good critic wants their target to succeed, and celebrates when that happens.

replies(3): >>43795805 #>>43796696 #>>43801816 #
memhole ◴[] No.43796696[source]
Very accurate description. I think this gets missed sometimes. Sometimes you’re criticizing because you know a subject well and want to see it improved.
replies(1): >>43796936 #
atq2119 ◴[] No.43796936[source]
See also: code review
replies(1): >>43797665 #
1. tpmoney ◴[] No.43797665{3}[source]
Two things I try to do in every code review:

If I’m doing the review, I try to find at least one or two items to call out as great ideas/moves. Even if it’s as simple as refactoring a minor pain point.

If I’m being reviewed I always make sure to thank/compliment comments that either suggest something I genuinely didn’t consider or catch a dumb move that isn’t wrong but would be a minor pain point in the future.

As you note, code reviews can be largely “negative feedback” systems, and I find encouraging even a small amount of positivity in the process keeps it from becoming soul sucking

replies(1): >>43800444 #
2. hackpelican ◴[] No.43800444[source]
In some companies, (ahem… Amazon), engineers are judged by their code review/comment ratio. Especially L4 engineers trying to make it to L5.

So actually putting positive comments in the code review isn’t really much appreciated.

I gained this habit and now for me, a comment is a suggestion of improvement, I deliver praise out-of-band.

replies(2): >>43801064 #>>43803359 #
3. wavemode ◴[] No.43801064[source]
> engineers are judged by their code review/comment ratio

It's a horrible practice with adverse incentives, and one of the reasons I'm glad I no longer work there

(and easily gameable, anyways - people would just DM each other patches they were unsure of, before submitting an actual CR)

4. tpmoney ◴[] No.43803359[source]
The more I learn about how the bigger companies do business, the happier I am my dreams of working for them never materialized. I encounter enough stupid things caused by businesses trying to measure difficult things. I would hate to work in a place where the proper mode of conduct – praise in public, criticize in private – is flipped on its head for the purposes of someone's spreadsheet.