←back to thread

293 points ulrischa | 1 comments | | HN request time: 0.305s | source
1. 256_ ◴[] No.42180883[source]
Some people are pretty negative about the code presented here (which the author criticised in a second post[0]), which makes me wonder, as someone who thankfully hasn't programmed anything non-trivial in Javascript in years: Is checking for (0,0) actually bad code, or is it simply making the most of a bad API?

Bear in mind the following:

> Also, thank you to Patrick H. Lauke from TetraLogical (editor of the Pointer Events Level 2 spec) for his comment on Mastodon that suggested improving the offending code by checking for pointerType in the PointerEvent interface instead of screenX and screenY.

The code provided in the second post[0] uses pointerType if available, else falls back to checking for (0,0). Also:

> At the time this code was originally written four years ago, not all browsers treated click events as PointerEvents. They used the MouseEvent interface, so pointerId or pointerType wasn't an option.

[0]: https://www.joshtumath.uk/posts/2024-11-18-how-i-refactored-...