←back to thread

31 points cmpit | 1 comments | | HN request time: 0.203s | source
Show context
cranberryturkey ◴[] No.41913474[source]
fun fact: after 25 years as a software engineer in silicon valley, I'm convinced nobody cares about code quality and they never have.
replies(3): >>41917529 #>>41918189 #>>41919143 #
1. everforward ◴[] No.41918189[source]
They do, but very few people are good enough to either write a pull request or review one well. I wouldn’t put myself in the really good category for either.

Most people write pull requests that are scoped too poorly to tell what they’re doing. Like I get a single function with unit tests, so the best I can do for a review is check whether there are any obvious missed edge cases for a function whose purpose I don’t understand.

On the review side, most people review by doing basically what a linter does. I joke with people that if they want to nitpick my variable names then I’ll start DMing them to ask what name they want every time I need a variable. A meaningful review would analyze whether abstractions are good, whether there is behavior that relies on an unspecified part of an abstraction (timing), etc. Nobody does those.