←back to thread

15 points cmpit | 6 comments | | HN request time: 0.981s | source | bottom
1. cranberryturkey ◴[] No.41913474[source]
fun fact: after 25 years as a software engineer in silicon valley, I'm convinced nobody cares about code quality and they never have.
replies(2): >>41917529 #>>41918189 #
2. stuckinhell ◴[] No.41917529[source]
I have 23 years,and I'm convinced too.
replies(2): >>41917570 #>>41918178 #
3. souldeux ◴[] No.41917570[source]
Only a dozen but same. Just ship the shit. Quality never mattered.
4. mewpmewp2 ◴[] No.41918178[source]
Also most attempts at code quality lead to even worse code - into overengineered abstraction layers that no one will be able to adjust once it's inevitably realized that the assumptions were all wrong.
replies(1): >>41918259 #
5. everforward ◴[] No.41918189[source]
They do, but very few people are good enough to either write a pull request or review one well. I wouldn’t put myself in the really good category for either.

Most people write pull requests that are scoped too poorly to tell what they’re doing. Like I get a single function with unit tests, so the best I can do for a review is check whether there are any obvious missed edge cases for a function whose purpose I don’t understand.

On the review side, most people review by doing basically what a linter does. I joke with people that if they want to nitpick my variable names then I’ll start DMing them to ask what name they want every time I need a variable. A meaningful review would analyze whether abstractions are good, whether there is behavior that relies on an unspecified part of an abstraction (timing), etc. Nobody does those.

6. fragmede ◴[] No.41918259{3}[source]
Totally. YAGNI - you ain't gonna need it. That beautiful framework you spent extra weeks writing, designing from first principles, turns out to be the wrong layer of abstraction because of a bad assumption. the client left off critical business logic details, or a pivot to a more popular feature of the program. The only question then is how to get out of that tech debt.