←back to thread

GitHub no longer uses Toasts

(primer.style)
123 points samsolomon | 5 comments | 08 Dec 25 19:58 UTC | HN request time: 0.206s | source
Show context
projektfu ◴[08 Dec 25 22:59 UTC] No.46198856[source]▶
Lecturing about accessibility with latency so high that you have no idea if any clicks are actually meaningful. I click "banners" and there's no indication anything is happening until 3 seconds later, when it takes me to a page that doesn't directly talk about banners until later. Then there is a link there that says "banners", and takes me to a different page, 3 seconds later. No indication that anything is happening or waiting during that time.
replies(2): >>46199981 #>>46204414 #
1. kurisufag ◴[09 Dec 25 00:56 UTC] No.46199981[source]▶
that's just an <a href> link. the only latency is your browser pulling the (admittedly, unnecessarily large) page -- would you prefer some static hydration garbage?
replies(2): >>46201855 #>>46205490 #
2. locknitpicker ◴[09 Dec 25 06:23 UTC] No.46201855[source]▶
> that's just an <a href> link. the only latency is your browser pulling the (admittedly, unnecessarily large) page

I fail to see the relevance of your comment. So you came up with an explanation of why the page might have awful accessibility. How does this make the accessibility problem any better?

> would you prefer some static hydration garbage?

I think everyone would prefer to not wait 3 seconds to get feedback on what they clicked. We're talking about accessibility, right?

replies(1): >>46202927 #
3. kurisufag ◴[09 Dec 25 09:14 UTC] No.46202927[source]▶
it's a link. if your browser doesn't have some visual cue that a load is occuring (for me it's a favicon indicator and a visual loading bar) you're having a client issue.

>How does this make the accessibility problem any better?

it's not a UX decision to load slowly on poor uplinks (fwiw it's near-instant on my machine). obviously nobody would /choose/ to do that.

toasts, though, are a definitely conscious UX choice.

replies(1): >>46204755 #
4. isleyaardvark ◴[09 Dec 25 13:33 UTC] No.46204755{3}[source]▶
The :active pseudoclass has been used to change the appearance of links since the beginning. (Probably in part because loading links was considerably slower back then.) Not giving links an :active style is a bizarre oversight.
5. projektfu ◴[09 Dec 25 14:49 UTC] No.46205490[source]▶
It's not a real link - some JS magic is happening behind the scenes. Otherwise there would be a confirmation something is happening like the browser's usual spinner.