(emilkowal.ski)

117 points FragrantRiver | 1 comments | 03 Dec 25 14:51 UTC | HN request time: 0.194s | source

Show context

robin_reala ◴[07 Dec 25 16:13 UTC] No.46182756[source]▶

Meanwhile, GitHub is removing Toasts from Primer, their design system.[1] They’re next to impossible to implement in a way that retains accessibility across all needs, and if you try to restrict their usage to places where accessibility doesn’t matter so much (simple ephemeral confirmations) people misuse them anyway.

It’s notable that accessibility isn’t mentioned once in this post, or, in fact, in the component’s documentation.

[1] https://primer.style/accessibility/toasts/

replies(5): >>46183323 #>>46184146 #>>46186685 #>>46187013 #>>46189172 #

1. akersten ◴[08 Dec 25 06:45 UTC] No.46189172[source]▶

>>46182756 #

GitHub is also limiting the new PR review page to only show 40 comments from reviewers. Who knows which 40. If you want to see more, they have a banner that tells you to switch back to the legacy view. No idea if they'll just silently lose the feature of "seeing all your PR's comments" once the legacy view is discontinued.

So I wouldn't take any inferences from their design system as gospel.

↑

Building a Toast Component