←back to thread

Nook Browser

(browsewithnook.com)
138 points ray__ | 1 comments | | HN request time: 0s | source
Show context
LoganDark ◴[] No.46170631[source]
I think I like the idea, but the structure of the code doesn't look the best. What most sticks out to me is the "Managers" directory. I've seen similar patterns before, even at my current place of work, but they seem to correlate with less experienced implementations. For instance, I clicked on one of them randomly and already found an issue: https://github.com/nook-browser/Nook/blob/09a4c6957a2e9fd7c5...

I guess `www.` (and only `www.`) is always special, and the only TLDs with two components are `"co.uk", "co.jp", "com.au", "co.nz", "com.br"`?

I don't know how critical this "Manager" is (what even is a "boost"?), but a web browser should absolutely have a proper list of TLDs!

replies(3): >>46170983 #>>46171380 #>>46171980 #
1. grodriguez100 ◴[] No.46171380[source]
Uh oh. Looks bad.