←back to thread

35 points Terretta | 1 comments | | HN request time: 0s | source
Show context
r1cka ◴[] No.45772653[source]
I think people worry too much about branch names. Feature branches are usually ephemeral. Prefix your branch with your personal identifier so I know who is primary on it and worry more about the commit message which will live on indefinitely.
replies(5): >>45772677 #>>45773377 #>>45773466 #>>45774133 #>>45774578 #
focom ◴[] No.45774578[source]
Commit message should be ephemeral too. Squashing after a PR should be the default. Only at that moment does the PR/Commit message matter.
replies(2): >>45774768 #>>45780891 #
1. xorcist ◴[] No.45780891[source]
Did you mean before the PR? Why would anyone have a review system if you change the code after review?

Hopefully the commits are already squashed and rebased before review to value reviewers' time.