←back to thread

35 points Terretta | 2 comments | | HN request time: 0s | source
Show context
r1cka ◴[] No.45772653[source]
I think people worry too much about branch names. Feature branches are usually ephemeral. Prefix your branch with your personal identifier so I know who is primary on it and worry more about the commit message which will live on indefinitely.
replies(5): >>45772677 #>>45773377 #>>45773466 #>>45774133 #>>45774578 #
focom ◴[] No.45774578[source]
Commit message should be ephemeral too. Squashing after a PR should be the default. Only at that moment does the PR/Commit message matter.
replies(2): >>45774768 #>>45780891 #
bavent ◴[] No.45774768[source]
Hard disagree here. GitHub does encourage this sort of thing, but even there for my PRs to be easily reviewable, I like to keep my commits organized and with good messages explaining things. That way the reviewer can walk the commits, and see why each thing was thing was done.

I also like it for myself, when I’m going over my own PRs before asking for a review - I will often amend commits to ensure the work is broken down correctly, each thing that should go together, does.

In a way, stacked PRs are just a higher-level abstraction of this too - same idea, keep work that goes together in the same place.

replies(2): >>45774846 #>>45776441 #
1. focom ◴[] No.45776441{3}[source]
> In a way, stacked PRs are just a higher-level abstraction of this too - same idea, keep work that goes together in the same place.

You downvote me but you just agreed with me. When was the last time you read individual commits of a PR? If your PR need to keep the history of the commits that means that you should split your PR into smaller one.

replies(1): >>45778858 #
2. bavent ◴[] No.45778858[source]
Calm down dude, I can’t even downvote people.

The last time I read individual commits of a PR? Maybe two hours ago. Before that, maybe five hours ago. Not everyone works like you do. Some people like clean commits. As I said, it’s very helpful when reviewing a PR, for me. I never said it was helpful for you.