←back to thread

Apple Photos app corrupts images

(tenderlovemaking.com)
1119 points pattyj | 1 comments | 17 Sep 25 11:07 UTC | HN request time: 0s | source
Show context
deviation ◴[17 Sep 25 11:47 UTC] No.45274615[source]▶
It seems to be an import pipeline bug.

Photos does a lot of extra work on import (merging RAW+JPEG pairs, generating previews, database indexing, optional deletion), so my guess is a concurrency bug where a buffer gets reused or a file handle is closed before the copy finishes.

Rare, nondeterministic corruption fits the profile.

replies(7): >>45274840 #>>45275400 #>>45275556 #>>45275634 #>>45277188 #>>45278171 #>>45280431 #
mentos ◴[17 Sep 25 13:32 UTC] No.45275634[source]▶
Sounds like an argument for Apple to provide a new high-level media import framework?
replies(1): >>45276469 #
Someone ◴[17 Sep 25 14:44 UTC] No.45276469{3}[source]▶
Why? A new framework gets you new bugs instead of the old ones, but not necessarily fewer or less severe ones.

It’s more likely that things will be reversed: the old, battle-tested framework may have bugs, but it’s is less likely to have serious ones.

They should try to hunt down bugs in the existing code. A partial rewrite of parts that historically have many bugs may be in order, but a complete replacement? Unlikely to be an improvement.

replies(1): >>45276837 #
1. mentos ◴[17 Sep 25 15:12 UTC] No.45276837{4}[source]▶
Well I'd imagine the new framework wouldn't rewrite old but wrap the existing low level APIs in a way that is not error prone. Centralize the tricky bits so Photos and third party apps don’t each have to reinvent them?