←back to thread

Campfire: Web-Based Chat Application

(github.com)
69 points thunderbong | 3 comments | 07 Sep 25 16:40 UTC | HN request time: 0.525s | source
Show context
nomilk ◴[07 Sep 25 17:11 UTC] No.45160043[source]▶
Reading through some controllers and models, haven't encountered a single code comment yet, just chiselled-out ruby.

Arbitrary examples:

https://github.com/basecamp/once-campfire/blob/main/app/cont...

https://github.com/basecamp/once-campfire/blob/main/app/cont...

https://github.com/basecamp/once-campfire/blob/main/app/mode...

replies(4): >>45160157 #>>45160222 #>>45160923 #>>45161406 #
1. wereHamster ◴[07 Sep 25 18:33 UTC] No.45160923[source]▶
Could it be that they removed /all/ comments from the codebase when they made it public, to not release some sensitive information that was in them?
replies(2): >>45161036 #>>45161389 #
2. micromacrofoot ◴[07 Sep 25 18:48 UTC] No.45161036[source]▶
possible, but I've worked in similar sized codebases that didn't use them intentionally (linted them out)

the idea being that the code should be readable enough to not require then

3. jbl0ndie ◴[07 Sep 25 19:29 UTC] No.45161389[source]▶
We're a Ruby shop and we have pretty much zero commented code. Ruby's intended to be readable enough not to need them and when we do need them, it's a sure sign we need some refactoring.