(github.com)

69 points thunderbong | 2 comments | 07 Sep 25 16:40 UTC | HN request time: 0.022s | source

Show context

nomilk ◴[07 Sep 25 17:11 UTC] No.45160043[source]▶

>>45159742 (OP) #

Reading through some controllers and models, haven't encountered a single code comment yet, just chiselled-out ruby.

Arbitrary examples:

https://github.com/basecamp/once-campfire/blob/main/app/cont...

https://github.com/basecamp/once-campfire/blob/main/app/mode...

replies(4): >>45160157 #>>45160222 #>>45160923 #>>45161406 #

mdaniel ◴[07 Sep 25 17:26 UTC] No.45160222[source]▶

>>45160043 #

I got a kick out of seemingly server-side browser blocking https://github.com/basecamp/once-campfire/blob/eecdb29332527... without one iota of "but, why?"

replies(1): >>45160276 #

1. gls2ro ◴[07 Sep 25 17:30 UTC] No.45160276[source]▶

>>45160222 #

I dont know for sure why but could it be that they are using importmaps and so it needs some browser versions to support it out of the box.

One the other hand there is an advantage to use importmaps removing the dependency on nodejs for FE assets thus making both DX and deployment a breeze.

replies(1): >>45160775 #

2. mdaniel ◴[07 Sep 25 18:16 UTC] No.45160775[source]▶

>>45160276 (TP) #

(a) reasonable guess, but it seems no, given https://caniuse.com/import-maps cites FF 108(!) versus the forbidden 120

(b) ok, fine, then include any english anywhere (in the source code, in the incompatible_browser.html.erb, in CLAUDE.md, whatever) so future generations would have any sane reason to mutate those magic numbers

↑

Campfire: Web-Based Chat Application