←back to thread

205 points samspenc | 2 comments | | HN request time: 0s | source
Show context
adithyassekhar ◴[] No.45146246[source]
This reminded me, I saw tooltips being a large chunk when I profiled my react app. I should go and check that.

Similarly, adding a modal like this

{isOpen && <Modal isOpen={isOpen} onClose={onClose} />}

instead of

<Modal isOpen={isOpen} onClose={onClose} />

Seems to make the app smoother the more models we had. Rendering the UI (not downloading the code, this is still part of the bundle) only when you need it seems to be a low hanging fruit for optimizing performance.

replies(4): >>45146382 #>>45146410 #>>45147091 #>>45147510 #
aiiizzz ◴[] No.45147091[source]
That breaks the out transition.
replies(8): >>45147226 #>>45147342 #>>45147669 #>>45148400 #>>45148647 #>>45150589 #>>45150865 #>>45153296 #
1. amatecha ◴[] No.45147226[source]
So, win-win? I want a modal to get out of the way as fast as possible, any fade/transition animations are keeping me from what I want to look at. :)
replies(1): >>45151902 #
2. chamomeal ◴[] No.45151902[source]
The designers don’t want to break the out transition, and the PM wants whatever the designer wants