←back to thread

105 points robbyrussell | 1 comments | | HN request time: 0s | source
Show context
chuckadams ◴[] No.45075489[source]
Laravel has taught me many things about maintainability, but it's mostly "don't write code like Laravel". My favorite is how cache tagging was broken in Laravel, and there was a complete PR presented to fix it, but Taylor just summarily closed the PR and removed all mention of cache tagging from the documentation instead.
replies(3): >>45077520 #>>45077934 #>>45078712 #
Implicated ◴[] No.45077520[source]
What was/is broken? I've been using cache tagging for years and haven't seen any issues.
replies(1): >>45077561 #
chuckadams ◴[] No.45077561[source]
Apparently a severe memory leak: https://old.reddit.com/r/laravel/comments/16yr8rb/why_were_c...

The PR in question: https://github.com/laravel/framework/pull/48078

replies(1): >>45078205 #
1. Implicated ◴[] No.45078205[source]
Thanks for those - turns out, I'm just lucky and have been using in a manner this never reared its head in my (only one) application where they're used. Heavily. But with the way things are done - the tagged caches were only flushed during a time that there were never going to be new keys added.