←back to thread

Delete tests

(andre.arko.net)
125 points mooreds | 2 comments | 27 Aug 25 11:18 UTC | HN request time: 0.517s | source
Show context
dcminter ◴[30 Aug 25 04:15 UTC] No.45071880[source]▶
How about you fix the flakey tests?

The tests I'd delete are the ones that just test that the code is written in a particular way instead of testing the expected behaviour of thr code.

replies(3): >>45071959 #>>45072007 #>>45072191 #
1. silversmith ◴[30 Aug 25 04:56 UTC] No.45072007[source]▶
Came here to comment this. Most of the flakey tests are badly written, some warn you about bugs you don't yet understand.

Couple years ago I helped to bring a project back on track. They had a notoriously flakey part of test suite, turned out to be caused by a race condition. And a very puzzling case of occasional data corruption - also, turns out, caused by the same race condition.

replies(1): >>45073642 #
2. MoreQARespect ◴[30 Aug 25 11:02 UTC] No.45073642[source]▶
I tend to find that those bugs are in the extreme minority.

Most flakiness ends up being a bug in the test or nondeterminism exhibited by the code which users dont actually care about.