←back to thread

446 points talboren | 1 comments | | HN request time: 0s | source
Show context
muglug ◴[] No.45039093[source]
Improvements merged within the last two days by the WebKit team: https://github.com/orgs/community/discussions/170922#discuss...

For my sins I occasionally create large PRs (> 1,000 files) in GitHub, and teammates (who mostly all use Chrome) will sometimes say "I'll approve once it loads for me..."

replies(6): >>45039371 #>>45039546 #>>45039877 #>>45040882 #>>45043276 #>>45050622 #
patrickmay ◴[] No.45039371[source]
That seems essentially unreviewable. If you can share without violating an NDA, what kind of PR would involve that many files?
replies(6): >>45039414 #>>45039433 #>>45039455 #>>45039478 #>>45040667 #>>45041353 #
moffkalast ◴[] No.45041353[source]
Convert space indents to tabs, as god intended.
replies(1): >>45050078 #
itsgabriel ◴[] No.45050078[source]
as god indented, you mean?
replies(1): >>45061273 #
1. moffkalast ◴[] No.45061273[source]
I'm stealing that one, lmao