←back to thread

446 points talboren | 1 comments | | HN request time: 0s | source
Show context
PedroBatista ◴[] No.45039192[source]
The Github website is slow everywhere. It is truly a piece of shit software both in terms of performance but also UX/UI and everything in between.

It's a product of many cooks and their brilliant ideas and KPIs, a social network for devs and code being the most "brilliant" of them all. For day to day dev operations is something so mediocre even Gitlab looks like the golden standard compared to Github.

And no, the problem is not "Rails" or [ insert any other tech BS to deflect the real problems ].

replies(17): >>45039249 #>>45039365 #>>45039680 #>>45039841 #>>45040328 #>>45040430 #>>45041105 #>>45041125 #>>45041207 #>>45042280 #>>45042385 #>>45044131 #>>45046133 #>>45048521 #>>45050100 #>>45051138 #>>45062005 #
bob1029 ◴[] No.45039249[source]
> And no, the problem is not "Rails"

The problem is they abandoned rails for react. The old SSR GitHub experience was very good. You could review massive PRs on any machine before they made the move.

replies(10): >>45039310 #>>45039407 #>>45039686 #>>45040388 #>>45041936 #>>45043631 #>>45048845 #>>45049190 #>>45051019 #>>45051373 #
Zanfa ◴[] No.45040388[source]
I’m pretty sure they used to do syntax highlighting on the server before and it was fast. Now they send down unhighlighted text that seems to choke the browser with anything but the smallest diffs.
replies(2): >>45041029 #>>45041118 #
slt2021 ◴[] No.45041118[source]
the problem is developers having fast modern machines.

if they were forced to use slow machines, they would not be able to put out crap like that

replies(6): >>45041255 #>>45041536 #>>45043882 #>>45046904 #>>45047482 #>>45051651 #
mrbombastic ◴[] No.45041536[source]
M4 macbook pro and almost unusably slow
replies(1): >>45043661 #
lowwave ◴[] No.45043661[source]
Ah the wonders of SPA! I know there are lighter ones, but it is not the first time hearing things like React being slow. Of course, when one start to do sntax highlighting on the client side....
replies(2): >>45044718 #>>45044747 #
humpty-d ◴[] No.45044718{5}[source]
Various comments and links throughout the discussion of this post indicate that the problem is a mix of the sheer number of nodes and css. It has nothing to do with React or being a React SPA, which it's also not, unless you have some proof otherwise.
replies(1): >>45048806 #
bythreads ◴[] No.45048806{6}[source]
React and the most commonly used pattern inherently promotes an way to complex html Node structure and shitty css, especially if stuff like tailwind is used.

Now you CAN so it so that is not the case, but tbh i have never seen that in the wild -

replies(1): >>45049318 #
troupo ◴[] No.45049318{7}[source]
Lol. If anything, Tailwind isn't shitty CSS (because it's a very limited number of classes) unlike the gazillion one-off classes that CSS-in-JS or even BEM encourages

Edit: here's a good investigation on a real-enough app https://www.developerway.com/posts/tailwind-vs-linaria-perfo...

replies(1): >>45049443 #
1. typpilol ◴[] No.45049443{8}[source]
Yes what's with his comment?

Tailwind is probably one of the best considering you can use Vite to literally strip out all unused css easily.

And I think tailwind v4 does this automatically