←back to thread

The GitHub website is slow on Safari

(github.com)
446 points talboren | 1 comments | 27 Aug 25 09:43 UTC | HN request time: 0.221s | source
Show context
muglug ◴[27 Aug 25 13:03 UTC] No.45039093[source]▶
Improvements merged within the last two days by the WebKit team: https://github.com/orgs/community/discussions/170922#discuss...

For my sins I occasionally create large PRs (> 1,000 files) in GitHub, and teammates (who mostly all use Chrome) will sometimes say "I'll approve once it loads for me..."

replies(6): >>45039371 #>>45039546 #>>45039877 #>>45040882 #>>45043276 #>>45050622 #
patrickmay ◴[27 Aug 25 13:26 UTC] No.45039371[source]▶
That seems essentially unreviewable. If you can share without violating an NDA, what kind of PR would involve that many files?
replies(6): >>45039414 #>>45039433 #>>45039455 #>>45039478 #>>45040667 #>>45041353 #
1. cesarb ◴[27 Aug 25 15:01 UTC] No.45040667[source]▶
> what kind of PR would involve that many files?

A very simple example: migrating from JavaEE to JakartaEE. Every single Java source file has to have the imports changed from "javax." to "jakarta.", which can easily be thousands of files. It's also easy to review (and any file which missed that change will fail when compiling on the CI).