(github.com)

446 points talboren | 1 comments | 27 Aug 25 09:43 UTC | HN request time: 0.242s | source

Show context

muglug ◴[27 Aug 25 13:03 UTC] No.45039093[source]▶

Improvements merged within the last two days by the WebKit team: https://github.com/orgs/community/discussions/170922#discuss...

For my sins I occasionally create large PRs (> 1,000 files) in GitHub, and teammates (who mostly all use Chrome) will sometimes say "I'll approve once it loads for me..."

replies(6): >>45039371 #>>45039546 #>>45039877 #>>45040882 #>>45043276 #>>45050622 #

patrickmay ◴[27 Aug 25 13:26 UTC] No.45039371[source]▶

>>45039093 #

That seems essentially unreviewable. If you can share without violating an NDA, what kind of PR would involve that many files?

replies(6): >>45039414 #>>45039433 #>>45039455 #>>45039478 #>>45040667 #>>45041353 #

1. trenchpilgrim ◴[27 Aug 25 13:31 UTC] No.45039433[source]▶

>>45039371 #

Ones where you have a lot of generated files you commit into Git, and you change the output of the generator tool.

↑

The GitHub website is slow on Safari