←back to thread

446 points talboren | 10 comments | | HN request time: 0.001s | source | bottom
Show context
PedroBatista ◴[] No.45039192[source]
The Github website is slow everywhere. It is truly a piece of shit software both in terms of performance but also UX/UI and everything in between.

It's a product of many cooks and their brilliant ideas and KPIs, a social network for devs and code being the most "brilliant" of them all. For day to day dev operations is something so mediocre even Gitlab looks like the golden standard compared to Github.

And no, the problem is not "Rails" or [ insert any other tech BS to deflect the real problems ].

replies(17): >>45039249 #>>45039365 #>>45039680 #>>45039841 #>>45040328 #>>45040430 #>>45041105 #>>45041125 #>>45041207 #>>45042280 #>>45042385 #>>45044131 #>>45046133 #>>45048521 #>>45050100 #>>45051138 #>>45062005 #
bob1029 ◴[] No.45039249[source]
> And no, the problem is not "Rails"

The problem is they abandoned rails for react. The old SSR GitHub experience was very good. You could review massive PRs on any machine before they made the move.

replies(10): >>45039310 #>>45039407 #>>45039686 #>>45040388 #>>45041936 #>>45043631 #>>45048845 #>>45049190 #>>45051019 #>>45051373 #
1. DrBenCarson ◴[] No.45039310[source]
Well yeah, but just imagine how much money they’re saving by delivering a subpar experience!
replies(3): >>45039385 #>>45040527 #>>45040940 #
2. gchamonlive ◴[] No.45039385[source]
Or how much money they are capturing in investiments or corporate deals because of the tech stack
3. zozbot234 ◴[] No.45040527[source]
They're not even saving any money. Syntax highlighting is a trivial workload, whereas the average SPA spends a lot of time in pointless roundtrips that have the server send more data down the pipe than the SSR equivalent.
replies(2): >>45041038 #>>45047755 #
4. Elfener ◴[] No.45040940[source]
I guess if you say "we've made the UX worse" instead of "we've reduced costs but made the UX worse" to shareholders, they think of cost savings regardless.
5. sidewndr46 ◴[] No.45041038[source]
I'll play devils advocate - does it save them some storage space or bandwidth in the CDN that delivers Github?
replies(1): >>45041845 #
6. Asmod4n ◴[] No.45041845{3}[source]
That's a good question, without looking into any of the code id say bandwidth cost goes higher when moving away from server side rendering since you have to send the code for client side rending to each client which connects.
7. scrollaway ◴[] No.45047755[source]
Sending data is what’s trivial compared to compute… syntax highlighting is not trivial workload compared to that, you don’t know what you’re saying.
replies(1): >>45051527 #
8. sgarland ◴[] No.45051527{3}[source]
You say that, until you’re one of the unlucky people who discover that cloud DBs are just cloud VMs in disguise, and those cloud VMs have network throughput limits.

A fun part of a retro at my company last year was me explaining to a team, “had all of your pods’ requests succeeded, the DB would have been pushing out well over 200 Gbps, which is generally reserved for top-of-rack switches.” Of course, someone else then had to translate that into “4K Blu-Rays per second,” because web devs aren’t typically familiar with networking, racks, data centers…

replies(1): >>45052720 #
9. scrollaway ◴[] No.45052720{4}[source]
Serving static files off highly efficient, distributed CDNs is a solved problem. There's no "4K blu-rays per second" when you're talking about gzipped, highly cacheable text data.

If github has a million users visiting it per day on a FRESH cache, and all of them have to download at least 10 megabytes of text data (both of these numbers are far too high), you are at ... 0.015 "4k blurays per second". Yeah I think MS's datacenters will survive.

replies(1): >>45053088 #
10. zozbot234 ◴[] No.45053088{5}[source]
A single-page app is not serving "static files". It might serve an initial bundle, but literally everything after that is dynamically generated. There's no way you could serve those responses via a CDN.