←back to thread

519 points cantdutchthis | 1 comments | | HN request time: 0.208s | source
Show context
layer8 ◴[] No.44501626[source]
What does “Github supports these” mean here? Isn’t it the browser that has to support them?
replies(1): >>44501670 #
c-hendricks ◴[] No.44501670[source]
Github could (should) be doing some sanitation of the HTML included in the readme, so they absolutely could be removing some nasty things SVGs support
replies(1): >>44501773 #
layer8 ◴[] No.44501773[source]
But it’s just an image link to some SVG file. No HTML involved, only a Markdown image link that GitHub will render as an HTML <img src="…"/> element. The actual SVG file linked to isn’t even necessarily hosted by GitHub.
replies(2): >>44502270 #>>44505009 #
1. sweetgiorni ◴[] No.44505009[source]
If the SVG being linked to is hosted by GitHub, they could make arbitrary changes before serving it to the browser. IIRC, I uploaded an SVG in a GitHub comment and the resulting image had some of its interactive functionality removed. Of course, that situation is slightly different since the file was uploaded in a comment and not as part of a Git repo... but still.