←back to thread

Git Notes: Git's coolest, most unloved­ feature (2022)

(tylercipriani.com)
577 points Delgan | 1 comments | 22 Jun 25 09:14 UTC | HN request time: 0s | source
Show context
olejorgenb ◴[22 Jun 25 14:02 UTC] No.44347040[source]▶
What happens of you rebase a branch containing commits with notes attached?
replies(2): >>44347161 #>>44348081 #
jwilk ◴[22 Jun 25 14:20 UTC] No.44347161[source]▶
Notes are copied to from the original to the rewritten commit by default. See https://git-scm.com/docs/git-notes#Documentation/git-notes.t... for details.

But I have this in my IRC logs:

  < _jwilk> TIL git-notes rewriting doesn't work properly when doing amend within rebase. :/
replies(1): >>44349537 #
1. IshKebab ◴[22 Jun 25 19:20 UTC] No.44349537{3}[source]▶
Yeah I think that's a pretty big issue. Not going to be fun using git notes for code review if they get lost every time you squash or recreate commits.

One thing that would be really useful though - if you could somehow use git notes to tell Git not to download some blobs by default that would be great. It would solve the "someone added 100 MB of binary files to this project 5 years ago and then deleted them" problem.

That would be too useful though so I wont hold by breath.