←back to thread

Mozilla Firefox – Official GitHub repo

(github.com)
848 points thefilmore | 1 comments | 13 May 25 05:23 UTC | HN request time: 0.207s | source
Show context
bandrami ◴[13 May 25 06:03 UTC] No.43969975[source]▶
Pretty cool that Linus Torvalds invented a completely distributed version control system and 20 years later we all use it to store our code in a single place.
replies(29): >>43969999 #>>43970002 #>>43970008 #>>43970018 #>>43970019 #>>43970028 #>>43970031 #>>43970032 #>>43970036 #>>43970037 #>>43970142 #>>43970154 #>>43970198 #>>43970282 #>>43970314 #>>43970343 #>>43970418 #>>43970419 #>>43970431 #>>43970434 #>>43970451 #>>43970472 #>>43970541 #>>43970904 #>>43971268 #>>43971299 #>>43971387 #>>43971586 #>>43988717 #
IshKebab ◴[13 May 25 06:08 UTC] No.43970002[source]▶
Plenty of people use Codeberg and Gitlab. And it's still distributed - I don't need to lock files and ask coworkers if I can work on them.

Maybe if Git had native support for PRs and issues this wouldn't have happened. (And yes I'm aware of git send-email etc.)

replies(3): >>43970054 #>>43970113 #>>43970150 #
mhh__ ◴[13 May 25 06:36 UTC] No.43970113[source]▶
Git should have issue support or something like it as a convention but pull requests are an abomination that we are stuck with. No thank you.
replies(3): >>43970148 #>>43970157 #>>43970328 #
kace91 ◴[13 May 25 06:42 UTC] No.43970148[source]▶
Can you expand on that? I’m probably younger but I can’t imagine a more comfortable way to review code.
replies(3): >>43970331 #>>43970946 #>>43974284 #
eru ◴[13 May 25 07:08 UTC] No.43970331[source]▶
Pull requests are great, but the typical github UI isn't necessarily the best way to review code.

It's often useful. But sometimes you want to use other tools, like firing up your editor to explore.

replies(1): >>43974277 #
mhh__ ◴[13 May 25 15:52 UTC] No.43974277[source]▶
No, they're terrible. We should be reviewing stacks of commits not branches
replies(1): >>43977227 #
IshKebab ◴[13 May 25 20:18 UTC] No.43977227[source]▶
Why? A branch is a stack of commits.
replies(2): >>43977997 #>>43987967 #
1. Dylan16807 ◴[13 May 25 21:35 UTC] No.43977997[source]▶
The workflow I believe they're talking about is like a branch but you can have multiple versions of the branch as you develop and refine it.

And those updates are properly tracked by your version control, not done jankily by editing a commit and rebasing and force pushing.