←back to thread

A steam locomotive from 1993 broke my yarn test

(blog.cloudflare.com)
167 points jgrahamc | 4 comments | 02 Apr 25 13:10 UTC | HN request time: 0.685s | source
1. normie3000 ◴[02 Apr 25 15:41 UTC] No.43557945[source]▶
> git commit, which hooked into yarn test

There's the real wtf. How are you meant to commit a failing test? Or any other kind of work in progress?

replies(2): >>43558109 #>>43558214 #
2. computerfriend ◴[02 Apr 25 15:54 UTC] No.43558109[source]▶

    git commit -n
replies(1): >>43568142 #
3. zdragnar ◴[02 Apr 25 16:06 UTC] No.43558214[source]▶
You mark the failing test with "failing". The test runner knows that it might fail but doesn't fail the suite.

I'm not a big fan of git commit hooks, but it can give faster feedback than waiting for a CI runner to point out something that should have been obvious if you keep it light weight (such as style linting or compiler warnings).

Edit: replaced "Todo" with "failing" since we're talking about jest specifically: https://jestjs.io/docs/api#testfailingname-fn-timeout

4. normie3000 ◴[03 Apr 25 11:35 UTC] No.43568142[source]▶
Aha! I have a new alias!