←back to thread

492 points storf45 | 1 comments | | HN request time: 0.201s | source
Show context
walrushunter ◴[] No.42154141[source]
I'm an engineering manager at a Fortune 500 company. The dumbest engineer on our team left for Netflix. He got a pay raise too.

Our engineers are fucking morons. And this guy was the dumbest of the bunch. If you think Netflix hires top tier talent, you don't know Netflix.

replies(30): >>42154160 #>>42154170 #>>42154176 #>>42154207 #>>42154212 #>>42154215 #>>42154217 #>>42154219 #>>42154225 #>>42154276 #>>42154278 #>>42154295 #>>42154314 #>>42154327 #>>42154373 #>>42154379 #>>42154399 #>>42154413 #>>42154440 #>>42154466 #>>42154547 #>>42154591 #>>42154596 #>>42154612 #>>42154786 #>>42154904 #>>42154925 #>>42155154 #>>42156451 #>>42157645 #
Lammy ◴[] No.42154295[source]
I hope to never have a manager who is mentally stack ranking me and my coworkers in terms of perceived dumbness instead of in terms of any positive trait.
replies(4): >>42154339 #>>42154894 #>>42154920 #>>42155176 #
strken ◴[] No.42155176[source]
I'm not a manager and I don't stack rank people, but I am 100% capable of knowing when one of my co-workers or predecessors is a fucking moron.

The trick is to use my massive brain to root cause several significant outages, discover that most of them originate in code written by the same employee, and notice that said employee liked to write things like

    // @ts-nocheck
    // obligatory disabling of typescript: static typing is hard, so why bother with it?
    async function upsertWidget() {
      try {
        // await api.doSomeOtherThings({ ... })
        // 20 line block of commented-out useless code
        // pretend this went on much longer
        let result = await api.createWidget({ a, b, c })
        if (!result.ok) {
           result = await api.createWidget({ a, b }) // retries for days! except with different args, how fun
           if (!result.ok) {
             result = await api.updateWidget({ a, b, c }) // oh wait, this time we're updating
           }
        }
        // notice that api.updateWidget() can fail silently
        // also, the three function calls can each return different data, I sure am glad we disabled typescript
        return result
      } catch (error) {
        return error // I sure do love this pattern of returning errors and then not checking whether the result was an error or the intended object 
      }
    }

    function doSomething() {
      const widget = await upsertWidget()
    }
...except even worse, because instead of createWidget the name was something far less descriptive, the nesting was deeper and involved loops, there were random assignments that made no goddamn sense, and the API calls just went to an unnecessary microservice that was only called from here and which literally just passed the data through to a third party with minor changes. Those minor changes resulted in an internal API that was actually worse than the unmodified third party API.

I am so tired of these people. I am not a 10x rockstar engineer and not without flaws, but they are just so awful and draining, and they never seem to get caught in time to stop them ruining perfectly fine companies. Every try>catch>return is like an icy cat hand from the grave reaching up to knock my coffee off my desk.

replies(2): >>42155266 #>>42156551 #
spike021 ◴[] No.42155266[source]
Isn't that a problem with your code review process? Why is that person's code making it to production?

So again, maybe they're a bad employee but it seems like nothing's done to even try and minimize the risks they present.

replies(2): >>42155367 #>>42155799 #
krysp ◴[] No.42155367[source]
There's a disincentive to actively block PRs if you don't want your coworkers to think you are a bad colleague / not on their side. So you often see suboptimal code making its way to production. This has a worse effect the more terrible engineers there are.
replies(2): >>42155433 #>>42156064 #
1. mathgeek ◴[] No.42156064[source]
Turning this into an incentive that everyone values is a signal that a team has a great culture.