Most active commenters
  • gwbas1c(3)

←back to thread

362 points tosh | 35 comments | | HN request time: 1.242s | source | bottom
1. gwbas1c ◴[] No.42069673[source]
Classic story of a startup taking a "good enough" shortcut and then coming back later to optimize.

---

I have a similar story: Where I work, we had a cluster of VMs that were always high CPU and a bit of a problem. We had a lot of fire drills where we'd have to bump up the size of the cluster, abort in-progress operations, or some combination of both.

Because this cluster of VMs was doing batch processing that the founder believed should be CPU intense, everyone just assumed that increasing load came with increasing customer size; and that this was just an annoyance that we could get to after we made one more feature.

But, at one point the bean counters pointed out that we spent disproportionately more on cloud than a normal business did. After one round of combining different VM clusters (that really didn't need to be separate servers), I decided that I could take some time to hook up this very CPU intense cluster up to a profiler.

I thought I was going to be in for a 1-2 week project and would follow a few worms. Instead, the CPU load was because we were constantly loading an entire table, that we never deleted from, into the application's process. The table had transient data that should only last a few hours at most.

I quickly deleted almost a decade's worth of obsolete data from the table. After about 15 minutes, CPU usage for this cluster dropped to almost nothing. The next day we made the VM cluster a fraction of its size, and in the next release, we got rid of the cluster and merged the functionality into another cluster.

I also made a pull request that introduced a simple filter to the query to only load 3 days of data; and then introduced a background operation to clean out the table periodically.

replies(6): >>42070228 #>>42070679 #>>42072931 #>>42073139 #>>42073360 #>>42073568 #
2. alsetmusic ◴[] No.42070228[source]
As much as you can say (perhaps not hard numbers, but as a percentage), what was the savings to the bottom line / cloud costs?
replies(1): >>42070472 #
3. gwbas1c ◴[] No.42070472[source]
Probably ~5% of cloud costs. Combined with the prior round of optimizations, it was substantial.

I was really disappointed when my wife couldn't get the night off from work when the company took everyone out to a fancy steak house.

replies(1): >>42070695 #
4. antisthenes ◴[] No.42070679[source]
99% of the time, it's either a quadratic (or exponential) algorithm or a really bad DB query.
replies(2): >>42070922 #>>42077743 #
5. chgs ◴[] No.42070695{3}[source]
So you saved the company $10k a month and got a $200 meal in gratitude? Awesome.
replies(7): >>42070984 #>>42071178 #>>42071275 #>>42071281 #>>42072406 #>>42073448 #>>42078121 #
6. dd82 ◴[] No.42070922[source]
can also be a linear algorithm that does N+1 queries. ORMs can be very good at hiding this implementation detail
replies(1): >>42071567 #
7. Cyphase ◴[] No.42070984{4}[source]
What should they have gotten?
replies(1): >>42071319 #
8. bagels ◴[] No.42071178{4}[source]
They're presumably already being paid a salary to do this work.
9. ponty_rick ◴[] No.42071275{4}[source]
They're more pissed about the 1.2M they spent than about the 10k a month they saved.
10. _hyn3 ◴[] No.42071281{4}[source]
> So you saved the company $10k a month and got a $200 meal in gratitude? Awesome.

You seem to be assuming that a $200 meal was the only compensation the person received, and they weren't just getting a nice meal as a little something extra on top of getting paid for doing their job competently and efficiently.

But that's the kind of deal I make when I take a job: I do the work (pretty well most of the time), and I get paid. If I stop doing the work, I stop getting paid. If they stop paying, I stop doing the work. (And bonus, literally, if I get a perk once in a while like a free steak dinner that I wasn't expecting)

It doesn't have to be more complicated than that.

replies(1): >>42071494 #
11. tempest_ ◴[] No.42071319{5}[source]
They are in theory owed nothing more than their salary but it can be very good for moral to reward that type of thing (assuming they are not introducing a perverse incentive)
12. meiraleal ◴[] No.42071494{5}[source]
Yeah? Well, proper rewards make those savings and optimizations more common. Otherwise most people will do the work needed just to have work tomorrow.
replies(2): >>42071927 #>>42072237 #
13. Quekid5 ◴[] No.42071567{3}[source]
> a linear algorithm that does N+1 queries.

That's what quadratic means.

replies(3): >>42072056 #>>42072666 #>>42079211 #
14. Sohcahtoa82 ◴[] No.42071927{6}[source]
It creates a perverse incentive to deliberately do things a more expensive way at the beginning and then be a hero 6 months down the line by refactoring it to be less expensive.
replies(1): >>42072745 #
15. sgerenser ◴[] No.42072056{4}[source]
Typically implemented accidentally: https://www.tumblr.com/accidentallyquadratic
16. groby_b ◴[] No.42072237{6}[source]
Depends. There are people who put in the absolute minimum work they can get away with, and there are people who have pride in their profession.

That's independent of pay scale.

Granted, if you pay way below expectations, you'll lose the professionals over time. But if you pay lavishly no matter what, you get the 2021/2022 big tech hiring cycle instead. Neither one is a great outcome.

replies(1): >>42076161 #
17. ChadNauseam ◴[] No.42072406{4}[source]
I'm not sure how they feel, but when it happens to me, it's not a big deal because it's my job to do things like that. If I fuck up and cost them $10k/month I'm certainly not going to offer to reimburse them.
18. jon_richards ◴[] No.42072666{4}[source]
Not really what they're talking about https://stackoverflow.com/questions/97197/what-is-the-n1-sel...
19. fn-mote ◴[] No.42072745{7}[source]
Ha ha, software developers already have this incentive. Viz: "superhero 10x programmer" writing unmaintainable code to provide some desirable features, whose work later turns out to be much less awesome than originally billed.

Of course the truth is more complicated than the sound bite, but still...

20. magundu ◴[] No.42072931[source]
Great.

It will be great if anyone write a checklist(playbook) to be checked for CPU, Memory, Disk, IO and network issues.

21. sly010 ◴[] No.42073139[source]
Hah. At a previous place I found that our cloud cost consisted of 90% storage costs. The data? Tens of thousands of incomplete backups of the in-office file server. 3 years of the NAS continuously trying to back itself up to S3 and failing every time.
22. declan_roberts ◴[] No.42073360[source]
I love these stories. I have a few as well. In the end I know we're all just doing our job, but I've been tempted at times to say to my manager: "I will save the company $10k/month tomorrow if you give me a cut of the pie."
replies(1): >>42075417 #
23. wellthisisgreat ◴[] No.42073448{4}[source]
Yeah, oppositely they should share the downsides of the burdens lol
24. misstercool ◴[] No.42073568[source]
It is a good problem to have for a startup, most startups are struggling finding customers to use their thing. Better to go with "good enough" shortcut and prioritize on growth. Recall is a YC company, I am sure they took advantage of huge amount AWS of credits in the first few years.
25. euroderf ◴[] No.42075417[source]
This should be the norm, actually.

It drives ya nuts to read a story where some guy on the shop floor saves his employer ten million dollars and to reward him they give him a 20% off coupon for Home Depot.

replies(3): >>42077354 #>>42077970 #>>42078375 #
26. meiraleal ◴[] No.42076161{7}[source]
A business that relies on people having pride in their profession won't scale. Proper rewards scale.
replies(1): >>42095293 #
27. freedomben ◴[] No.42077354{3}[source]
This sounds nice in theory, but would incentivize people to introduce unnecessarily expensive things initially and optimize them later to claim some of the savings. We would like to think that nobody would do something like that, but the sad reality is that there are plenty, especially as the potential reward goes up high enough.
28. DylanSp ◴[] No.42077743[source]
It wasn't a financial cost, but the biggest single performance improvement I've seen firsthand came from optimizing a SQL query. One of our Professional Services people had written a query that did repeated self-joins on a fairly large table, which took ~15 minutes to run. A DBA-turned-dev on our team rewrote it using MSSQL's PIVOT operator, and the query started executing in less than a second.
29. zuhsetaqi ◴[] No.42077970{3}[source]
> It drives ya nuts to read a story where some guy on the shop floor saves his employer ten million dollars and to reward him they give him a 20% off coupon for Home Depot.

It’s your job as an employee, it’s why you get paid in the first place

replies(2): >>42087759 #>>42095626 #
30. gwbas1c ◴[] No.42078121{4}[source]
The dinner was to celebrate getting acquired, which was a wide team effort. The cost savings I did was one of the pieces I contributed.

Don't assume that a steak dinner was the only recognition we got.

As far as comp: I was well taken care of, and I won't discuss more in a public forum.

31. 7jjjjjjj ◴[] No.42078375{3}[source]
Boss makes a dollar, I make a dime, that's why my code runs in exponential time.
32. nwellnhof ◴[] No.42079211{4}[source]
No, N+1 is still linear.
33. mgkimsal ◴[] No.42087759{4}[source]
Is it? Or is an employee's job to just do the work they're asked to do?

"It depends" is, of course, the common answer, but in most places I've worked, "please help find operational optimizations that can have a positive impact for the team, department or organization" has certainly never been an explicit ask.

Ask team mates to change something to help on a project may fall under the same category, but usually the effect isn't felt beyond a project.

My default mode when coming in to jobs is to try to get a 'full company' view, because I want to know how things work and how they might be made better. That approach is usually not met with much enthusiasm, and usually more with "that's not your job, you don't need to know that", etc.

I took a daily import routine that was taking 25+ hours (meaning we couldn't show 'daily info' because it was out of date before finishing import) and got it down to 30 minutes. This was after having to fight/argue to see the data, and being told for a couple weeks "it can't be sped up, we'll have to buy faster hardware" ($8-$10k min, but they weren't looking at $15-20k IIRC). I spent a few hours over a weekend and got it down to 30 minutes, and saved the company minimum $8k. But I had to fight/argue to even do that ("that's not your job", "Charles is taking care of that", "the client will just have to deal with more delays while we upgrade", etc).

34. groby_b ◴[] No.42095293{8}[source]
We demonstrated in 2022 that they don't.

There is no single mechanism that does. Paying well is always a component in attracting talent (see my original comment)

It is not a guarantor of quality/motivation. That's ongoing leadership work. And part of that is maintaining/kindling pride in people's work (and firing the ones who are just there for the money)

35. evoke4908 ◴[] No.42095626{4}[source]
Uh, no. Have you ever been employed? Your job is what is laid out in your contract, period. You are paid to do that specific set of tasks and nothing else. "Other duties as required" be damned.

Fixing the business is very explicitly not your job, and is absolutely not what you're paid for. Any value you create for the business outside of those bounds is at your own cost and you absolutely will not be compensated unless the business is so small you don't have six layers of management trying to extract any kind of promotion.