←back to thread

Redbox left PII on decommissioned machines

(digipres.club)
294 points NotPractical | 1 comments | 16 Oct 24 00:15 UTC | HN request time: 0.193s | source
Show context
xnorswap ◴[16 Oct 24 08:14 UTC] No.41856752[source]▶
> Redbox.HAL.Configuration

> .ConfigurationFileService implements IConfigurationFileService

> STOP MAKING SERVICES AND FACTORIES AND INTERFACES AND JUST READ THE FUCKING

> JSON FILE YOU ENTERPRISE FUCKERS

I know it's cool to "hate" on OO, but "just read the fucking file" doesn't work if you want to run your unit tests without reading a fucking file.

It makes sense to abstract configuration behind an interface so you can easily mock it our or implement it differently for unit testing.

Perhaps you also want to have some services configured through a database instead.

This isn't a ConfigurationFileServiceFactoryFactory.

replies(12): >>41856822 #>>41856831 #>>41856836 #>>41856965 #>>41857895 #>>41858054 #>>41859117 #>>41859509 #>>41859750 #>>41859882 #>>41860221 #>>41864182 #
rkachowski ◴[16 Oct 24 08:25 UTC] No.41856822[source]▶
most of these issues disappear with the introduction of first class functions. There's nothing noble about the thick indirection inherent in old school enterprise programming.
replies(1): >>41858756 #
1. gpderetta ◴[16 Oct 24 13:21 UTC] No.41858756[source]▶
A fist class function is just an interface. Just ask the venerable master Qc Na.