←back to thread

Box64 and RISC-V in 2024: What It Takes to Run the Witcher 3 on RISC-V

(box86.org)
366 points pabs3 | 3 comments | 27 Aug 24 04:23 UTC | HN request time: 0.208s | source
Show context
justahuman74 ◴[27 Aug 24 05:31 UTC] No.41364800[source]▶
I hope they're able to get this ISA-level feedback to people at RVI
replies(2): >>41364827 #>>41364904 #
camel-cdr ◴[27 Aug 24 06:01 UTC] No.41364904[source]▶
The scalar efficiency SIG has already been discussing bitfield insert and extract instructions.

We figured out yesterday [1], that the example in the article can already be done in four risc-v instructions, it's just a bit trickier to come up with it:

    # a0 = rax, a1 = rbx
    slli t0, a1, 64-8
    rori a0, a0, 16
    add a0, a0, t0
    rori a0, a0, 64-16
[1] https://www.reddit.com/r/RISCV/comments/1f1mnxf/box64_and_ri...
replies(2): >>41365275 #>>41369025 #
1. bonzini ◴[27 Aug 24 07:26 UTC] No.41365275[source]▶
Nice trick, in fact with 4 instructions it's as efficient as extract/insert and it works for all ADD/SUB/OR/XOR/CMP instructions (not for AND), except if the source is a high-byte register. However it's not really a problem if code generation is not great in this case: compilers in practice will not generate accesses to these registers, and while old 16-bit assembly code has lots of such accesses it's designed to run on processors that ran at 4-20 MHz.

Flag computation and conditional jumps is where the big optimization opportunities lie. Box64 uses a multi-pass decoder that computes liveness information for flags and then computes flags one by one. QEMU instead tries to store the original operands and computes flags lazily. Both approaches have advantages and disadvantages...

replies(2): >>41367296 #>>41375144 #
2. ptitSeb ◴[27 Aug 24 13:28 UTC] No.41367296[source]▶
Actually, Box64 can also store operands for later computation, depending on what comes next...
3. brucehoult ◴[28 Aug 24 01:32 UTC] No.41375144[source]▶
> except if the source is a high-byte register

That's just one more instruction, to right-align the AH, BH etc src operand prior to exactly the same instructions as above.

And, yes, this being 64 bit code compilers won't be generating such instructions. In fact they started avoiding them as soon as OoO hit in the Pentium Pro, P II, P III etc in the mid 90s because of "partial register update stalls".